cranelift: add icmp-of-icmp rules for comparisons with 1 #8510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
cranelift-icmp-icmp-1
branch
2 times, most recently
from
744855e
to
8d6dd2c
Compare
KGrewal1
reviewed
Apr 30, 2024
cranelift/codegen/src/opts/icmp.isle
Outdated
| (rule (simplify (eq ty | ||
| (uextend_maybe _ (icmp ty cc x y)) | ||
| (iconst_u _ 0))) | ||
| (subsume (icmp ty (intcc_complement cc) x y))) | ||
|
|
||
| ;; eq(icmp(ty, cc, x, y), 1) == icmp(ty, cc_complement, x, y) |
There was a problem hiding this comment.
are these comments the wrong way around (ie should this be
eq(icmp(ty, cc, x, y), 1) == icmp(ty, cc, x, y)
and similar for the documentation of the other command
?
There was a problem hiding this comment.
Indeed, thanks!
|
@tertsdiepraam thanks for this! The tests are in |
tertsdiepraam
force-pushed
the
cranelift-icmp-icmp-1
branch
from
8d6dd2c
to
27b5d2a
Compare
|
I've added tests both in |
cfallin
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @cfallin in this zulip thread: https://bytecodealliance.zulipchat.com/#narrow/stream/217117-cranelift/topic/disassemly.20seems.20.28relatively.29.20unoptimized
The icmp-of-icmp rules only included comparisons with 0. So this
gets simplified to
But the equivalent
did not get simplified, even though the rules to apply are just the inverse of the rules for 0.
I've added the rules for
icmp(..) == 1andicmp(..) != 1and tried to add some more comments to the existing rules.I need some help to figure out how I could write a test for this, because I haven't found the tests in the codebase :)