Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: Use ConstExpr for element segment offsets #8514

Merged
merged 2 commits into from
May 1, 2024

Conversation

jameysharp
Copy link
Contributor

@jameysharp jameysharp commented May 1, 2024

This shouldn't change any behavior currently, but prepares us for supporting extended constant expressions.

I have a separate commit for doing the same to data segments (#8515), but it needs more work.

This shouldn't change any behavior currently, but prepares us for
supporting extended constant expressions.
@jameysharp jameysharp requested a review from fitzgen May 1, 2024 08:27
@jameysharp jameysharp requested a review from a team as a code owner May 1, 2024 08:28
@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label May 1, 2024
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fitzgen fitzgen enabled auto-merge May 1, 2024 16:17
@jameysharp jameysharp disabled auto-merge May 1, 2024 18:32
@jameysharp jameysharp enabled auto-merge May 1, 2024 18:37
@jameysharp jameysharp added this pull request to the merge queue May 1, 2024
Merged via the queue into bytecodealliance:main with commit d4e968c May 1, 2024
21 checks passed
@jameysharp jameysharp deleted the elem-const-expr branch May 1, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants