Force some more permission checks with 0-length writes #8822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a 0-length write is performed try to send the write all the way to the underlying file descriptor to at least check that it's valid to write. Closes bytecodealliance#8818
Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
* Force some more permission checks with 0-length writes When a 0-length write is performed try to send the write all the way to the underlying file descriptor to at least check that it's valid to write. Closes #8818 * Update crates/test-programs/src/bin/preview1_file_write.rs Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com> --------- Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like the error differs on Windows and Linux. For now I've just updated the test to accept both errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 0-length write is performed try to send the write all the way to the underlying file descriptor to at least check that it's valid to write.
Closes #8818