Introduce the cranelift-bitset crate; use it for stack maps in both Cranelift and Wasmtime
#8826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eventual goal is to deduplicate bitset types between Cranelift and Wasmtime, especially their use in stack maps.
Mostly for stack maps, also for a variety of other random things where `cranelift_codegen::bitset::BitSet` was previously used.
fitzgen
requested review from
abrown and
elliottt
and removed request for
a team
| /// ``` | ||
| #[inline] | ||
| pub fn contains(&self, i: u8) -> bool { | ||
| assert!(i < Self::capacity()); |
There was a problem hiding this comment.
Given the perf-sensitive nature of bitsets should this be debug_assert!?
There was a problem hiding this comment.
I was thinking that originally, but figured we might as well do the more-correct thing by default and add unchecked versions later if profiling shows that these asserts actually matter.
I kind of expect LLVM to clean them all up, at least when they are called via CompoundBitSet methods, since it should be able to determine the ranges of values flowing into these methods based on the modulo operation in CompoundBitSet::word_and_bit.
Makes a bunch of other stuff easier, and will be needed for replacing `cranelift_entity::EntitySet`'s bitset with this thing anyways.
|
@alexcrichton this should be ready for a second round of review now. |
github-actions
bot
added
cranelift
alexcrichton
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.