Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Block type indices must be encoded as a sleb #62

Closed
eqrion opened this issue Feb 26, 2020 · 1 comment · Fixed by #63
Closed

Block type indices must be encoded as a sleb #62

eqrion opened this issue Feb 26, 2020 · 1 comment · Fixed by #63

Comments

@eqrion
Copy link
Contributor

eqrion commented Feb 26, 2020

[1] If not, when the number of types in a module grows too large, a uleb encoding will begin to be confused with a value type [3]. I believe the issue is here, where a type index is always encoded as a uleb [2].

[1] https://webassembly.github.io/multi-value/core/binary/instructions.html#control-instructions
[2]

Index::Num(n) => n.encode(e),

[3] https://searchfox.org/mozilla-central/rev/49ed791eec93335abfe6c2880f84c324e73e47e6/js/src/jit-test/tests/wasm/multi-value/block-validate.js#174

@alexcrichton
Copy link
Member

Oh man y'all got good tests :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants