refactor(*): move anonymous type definition to core #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this PR needs a huge rebase. @alexcrichton any suggestions if we should proceed with this refactoring? |
|
Oh dear I apologize I think github doesn't send out notifications for when a PR moves from draft to ready state, so I never saw this after it switched states. I think this is still reasonable to land though if you'd like to rebase! |
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Mossaka
force-pushed
the
move_anonymous_type
branch
from
a3534a5
to
58bdb16
Compare
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
|
@alexcrichton okay I finally found some time to rebase this PR. it's ready for review. |
alexcrichton
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
define_anonymous_typein C to the core crate, as I believe this is a common pattern in all wit binding languages generators. The benefit of this refactoring work is that language generator does not need to decide which types are anonymous and that is handled by the trait function itself.CC @alexcrichton