Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): add value codec #140

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Jun 18, 2024

  • Remove associated Error types, and use anyhow::Error in wrpc_transport traits to simplify downstream usage. I really wish there was a nicer way to handle this and std::io::Error is a real pain to use in this context
  • Add ValueEncoder and ValueDecoder drafts, the implementations will have to be expanded, but the idea is that users of wrpc_transport will implement Encoder and Decoder on these structs

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs added this pull request to the merge queue Jun 18, 2024
Merged via the queue into bytecodealliance:main with commit ddb220c Jun 18, 2024
25 checks passed
@rvolosatovs rvolosatovs deleted the feat/value-codec branch June 18, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant