fix: dispatch scope

bytedance · Jun 9, 2020 · 2628c73 · 2628c73
1 parent 624dee2
commit 2628c73
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 15 deletions.
diff --git a/packages/bytemd/src/editor.svelte b/packages/bytemd/src/editor.svelte
@@ -1,5 +1,5 @@
 <script>
-  import { onMount } from 'svelte';
+  import { onMount, createEventDispatcher } from 'svelte';
   import Toolbar from './toolbar.svelte';
   import Viewer from './viewer.svelte';
   import { dataUrlFileHandler, initEditor } from './utils';
@@ -24,8 +24,10 @@
     cm.setValue(value);
   }
 
+  const dispatch = createEventDispatcher();
+
   onMount(() => {
-    initEditor(textarea, editorConfig, value, viewer, fileHandler);
+    initEditor(textarea, editorConfig, value, viewer, fileHandler, dispatch);
   });
 </script>
 

diff --git a/packages/bytemd/src/utils/editor.ts b/packages/bytemd/src/utils/editor.ts
@@ -1,4 +1,3 @@
-import { createEventDispatcher } from 'svelte';
 import codemirror from 'codemirror';
 import 'codemirror/mode/markdown/markdown.js';
 import { EditorProps } from 'bytemd';
@@ -8,10 +7,9 @@ export function initEditor(
   editorConfig: any,
   value: string,
   viewer: HTMLElement,
-  fileHandler: NonNullable<EditorProps['fileHandler']>
+  fileHandler: NonNullable<EditorProps['fileHandler']>,
+  dispatch: any
 ) {
-  const dispatch = createEventDispatcher();
-
   const cm = codemirror.fromTextArea(textarea, {
     mode: 'markdown',
     lineNumbers: true,

diff --git a/packages/bytemd/src/utils/element.ts b/packages/bytemd/src/utils/element.ts
@@ -10,11 +10,3 @@ export function findPlugin(node: HastNode, plugins: BytemdPlugin[]) {
     }
   }
 }
-
-export const santitizeHref = (href?: string) => {
-  if (href && href.trim().toLowerCase().startsWith('javascript')) {
-    return;
-  } else {
-    return href;
-  }
-};
diff --git a/packages/bytemd/src/utils/index.ts b/packages/bytemd/src/utils/index.ts
@@ -1,6 +1,6 @@
 export { getParser } from './common';
 export { initEditor, dataUrlFileHandler } from './editor';
-export { findPlugin, santitizeHref } from './element';
+export { findPlugin } from './element';
 export {
   handleDec,
   handleTag,