fix(react): handle update

bytedance · Jun 13, 2020 · 5f2158f · 5f2158f
1 parent afe4cab
commit 5f2158f
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/packages/bytemd/react/src/index.tsx b/packages/bytemd/react/src/index.tsx
@@ -5,7 +5,11 @@ export interface EditorProps extends bytemd.EditorProps {
   onChange?(value: string): void;
 }
 
-export const Editor: React.FC<EditorProps> = (props) => {
+export const Editor: React.FC<EditorProps> = ({
+  children,
+  onChange,
+  ...props
+}) => {
   const ed = useRef<bytemd.Editor>();
   const el = useRef<HTMLDivElement>(null);
 
@@ -18,13 +22,16 @@ export const Editor: React.FC<EditorProps> = (props) => {
       props,
     });
     editor.$on('change', (e) => {
-      if (props.onChange) {
-        props.onChange(e.detail.value);
-      }
+      if (onChange) onChange(e.detail.value);
     });
     ed.current = editor;
   }, [el.current]);
 
+  useEffect(() => {
+    // TODO: performance
+    ed.current?.$set(props);
+  }, [props]);
+
   return <div ref={el}></div>;
 };