Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Clean all dart code #79

Closed
wants to merge 1 commit into from
Closed

Conversation

AlexV525
Copy link
Contributor

Pull Request Checklist

  • I have read the UME contribution document and understand how to contribute, commit the code according to the rules. 我已阅读过 UME 贡献文档,并了解如何进行贡献,按照规则提交了代码
  • I have added the necessary comments in code to ensure that other contributors can understand the reason for the change. 我在修改中已经添加了必要的注释,以确保便于其他贡献者理解修改原因
  • The code has been formatted by dartfmt before push. 代码在提交前已经经过 dartfmt 进行了格式化
  • Change does not involve the adjustment of test cases. Or all existing and new tests are passing. 改动不涉及测试用例调整,或 example 工程与单元测试已经完全跑通

@@ -10,7 +9,7 @@ import 'eye_dropper_overlay.dart';

final captureKey = GlobalKey();

class _EyeDropperModel {
class UMEEyeDropperModel {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code which under the 'third_party/cyclop' is copied from third repository. Because the third-repo author didn't merge my changes. I think we shouldn't modify code in our repo. Should we release a new pub component to modify these code?

@talisk
Copy link
Member

talisk commented Sep 22, 2022

@github-actions Flutter drive / drive_ios (iPhone 8) (pull_request) Failing after 1m
26s
Run subosito/flutter-action@v2.7.[1](https://github.com/bytedance/flutter_ume/actions/runs/3096437324/jobs/5011989193#step:6:1)
Run $GITHUB_ACTION_PATH/setup.sh -p -c '/Users/runner/hostedtoolcache/flutter/:channel:-:version:-:arch:' -k 'flutter-:os:-:channel:-:version:-:arch:-:hash:' -n 'any' -a 'x64' stable
Unable to determine Flutter version for channel: stable version: any architecture: x64
Error: Process completed with exit code 1.

@AlexV525 The pipeline looks failed again :|

@talisk
Copy link
Member

talisk commented Sep 22, 2022

It passed after retrying 😮‍💨

@talisk
Copy link
Member

talisk commented Sep 22, 2022

rxlabz/cyclop#11 Here's the PR of cyclop.

@AlexV525 AlexV525 closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants