Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark step in .github/workflows/pr-check looks like nop #28

Closed
luchsh opened this issue May 11, 2021 · 1 comment · Fixed by #95
Closed

Benchmark step in .github/workflows/pr-check looks like nop #28

luchsh opened this issue May 11, 2021 · 1 comment · Fixed by #95

Comments

@luchsh
Copy link
Collaborator

luchsh commented May 11, 2021

For now it just runs benchmarking and does not check results, which looks like nop effectively.

For each Pull Request, need a mechanism to determine the benchmarking result is positive or negative?

@PureWhiteWu
Copy link
Collaborator

是的,最好是能和 base 进行比较,这个需要看看有没有啥好的插件之类的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants