Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make native builds part of maven build? #170

Closed
jjYBdx4IL opened this issue Mar 1, 2016 · 3 comments
Closed

make native builds part of maven build? #170

jjYBdx4IL opened this issue Mar 1, 2016 · 3 comments

Comments

@jjYBdx4IL
Copy link

See https://github.com/jjYBdx4IL/javacpp-presets/blob/pulldown/opencv/pom.xml

I'm using maven-download-plugin for downloads there (it caches the downloads inside the user's local maven repo) and the maven antrun plugin to run the cppbuild.sh script. That way we could also declare versions centrally in the javacpp-presets pom.xml and feed them to the scripts.

@saudet
Copy link
Member

saudet commented Mar 2, 2016

That's a nice idea :) A couple of things though. We don't need maven-download-plugin because cppbuild.sh already does caching and everything we need. Also, would it be possible to move the maven-antrun-plugin to the parent pom.xml file as part of the pluginManagement element? And I think we should bind the execution to "generate-resources", which makes more sense than "generate-sources", what do you think? And I'm pretty sure we'll need to explicitly run "bash" on Windows for this to work. If that makes sense, and can make the necessary modifications, send a pull request and I'll merge this in! Thanks

@saudet
Copy link
Member

saudet commented Mar 27, 2016

Merged from #175, thanks for the contribution!

@saudet
Copy link
Member

saudet commented May 19, 2016

Included in the release of version 1.2. Again, thanks for the contribution!

BTW, I would be very interested if you could continue your work to turn all the samples of all the presets into tests for surefire or failsafe...

@saudet saudet closed this as completed May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants