Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use antrun maven plugin to run cppbuild scripts within the maven build #175

Merged
merged 1 commit into from
Mar 12, 2016
Merged

use antrun maven plugin to run cppbuild scripts within the maven build #175

merged 1 commit into from
Mar 12, 2016

Conversation

jjYBdx4IL
Copy link

No description provided.

@saudet
Copy link
Member

saudet commented Mar 5, 2016

Looks good, thanks! But the maven-antrun-plugin screws up the output of the script. exec-maven-plugin doesn't appear to have that problem, so could we use that instead?

And we need to pass on the user-specified javacpp.platform property to the -platform option of the script. And I'll merge that in! thanks :)

@jjYBdx4IL
Copy link
Author

yeah that's better

@saudet
Copy link
Member

saudet commented Mar 7, 2016

Looks good! So, could you squash this into one commit so it will merge cleanly?

BTW, the environment variables set aren't used for anything yet, so we could remove them, but if you'd like to keep them, let's make the names consistent. Something like the following maybe?

            <PROJECT_VERSION>${project.version}</PROJECT_VERSION>
            <PROJECT_BASEDIR>${project.basedir}</PROJECT_BASEDIR>

Thanks!

@jjYBdx4IL
Copy link
Author

done

@saudet
Copy link
Member

saudet commented Mar 12, 2016

Thanks!

saudet added a commit that referenced this pull request Mar 12, 2016
 * Execute the `cppbuild.sh` scripts within the Maven build lifecycle
@saudet saudet merged commit 71902d2 into bytedeco:master Mar 12, 2016
saudet added a commit that referenced this pull request Mar 12, 2016
…R files (pull bytedeco/javacpp#89)

 * Execute the `cppbuild.sh` scripts within the Maven build lifecycle, can be skipped with `-Djavacpp.cppbuild.skip` (pull #175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants