Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-armhf additions #279

Merged
merged 1 commit into from
Sep 11, 2016
Merged

linux-armhf additions #279

merged 1 commit into from
Sep 11, 2016

Conversation

vb216
Copy link
Member

@vb216 vb216 commented Sep 4, 2016

Hopefully these fix the lot for arm-hf, seems to build OK with:
mvn install -Djavacpp.platform=linux-armhf -Dplatform=linux-armhf -Dplatform.compiler=arm-linux-gnueabihf-g++ -Djavacpp.platform.compiler=arm-linux-gnueabihf-g++

to build all the presets. Only bit to check, I modified cuda and took out the linux-arm - I'm not sure that would be used? Otherwise needs some way to not try and build it for linux-armhf?

@saudet
Copy link
Member

saudet commented Sep 4, 2016

You were not able to build for CUDA with their binaries for ARM? We might want to let them know...

@vb216
Copy link
Member Author

vb216 commented Sep 4, 2016

I thought since 6.5 it was only 64 bit?

@saudet
Copy link
Member

saudet commented Sep 4, 2016

Oh yeah, looks like they dropped ARM. Ok, that's fine then.

@saudet
Copy link
Member

saudet commented Sep 10, 2016

Specifying "linux_x86" will also disable "linux-x86_64" and "linux-x86_64". It should be "linux-x86", with a hyphen, not an underscore.

The idea with FFTW is to build both fftw3 and fftw3f, so if we build both in the cppbuild.sh script (using the --enable-float flag to get fftw3f), we shouldn't need to modify the presets.

Otherwise looks good! When you get sometime to fix the above, I'll be merging this. Thanks

@vb216
Copy link
Member Author

vb216 commented Sep 10, 2016

Ah sorry.. looks like a typo, should have spotted that one. Hopefully a CI system checking pull requests will pick that up ;)

Fixed the FFTW one too, looks better with the enable float flag.
Hope thats all OK now - I rebuilt and goes through fine, apart from OpenBLAS that we know about.

@saudet
Copy link
Member

saudet commented Sep 10, 2016

Thanks! AFAIK, we need to call the build for FFTW twice to get both libraries. Just do like linux-x86, it should work :) And then we don't need to modify the presets

@vb216
Copy link
Member Author

vb216 commented Sep 11, 2016

Done! Rechecked it out + built fftw to check, looks OK. I guess it would have shown up if I did a clean rebuild on the last attempt, hopefully all good now.

@saudet
Copy link
Member

saudet commented Sep 11, 2016

Yes, looks good now. Thanks!

@saudet saudet merged commit 65bd9bf into bytedeco:master Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants