Deadlock on ffmpeg+x264 for windows encode with tune=zerolatency #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmpeg+x264 for windows use by default windows native threads (win32thread), while ffmpeg+x264 in javacpp use pthread. ffmpeg+x264 in javacpp take deadlocks in encoding when setting tune option to zerolatency that is x264's option.
|
Seems to be working fine now, yes. Please remove the remaining "--disable-w32threads" and "--enable-pthreads" and we can merge this I think. Thanks! |
|
Thank you quick response @saudet !! |
|
No, you can make modifications by pushing commits to the branch you created on your fork. They will automatically appear in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffmpeg+x264 for windows use by default windows native threads (win32thread),
while ffmpeg+x264 in javacpp use pthread.
ffmpeg+x264 in javacpp take deadlocks in encoding
when setting tune option to zerolatency that is x264's option.