Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Removed missing Java 9 package exports #880

Merged
merged 1 commit into from
May 5, 2020
Merged

[CUDA] Removed missing Java 9 package exports #880

merged 1 commit into from
May 5, 2020

Conversation

Brownshome
Copy link
Contributor

The produced cuda jar is now considered valid as a Java 9 module.

I'm not sure if the packages being missing are a symptom of an underlying issue, or if the module file was in error. I also checked a few of the other Jars (any jar that was being used by deeplearning4j to be precise) and they all are accepted into a Java 9+ build.

The command java -p JAR --describe-module MODULE can be used to check any produced jars.

Old

> java -p .\cuda-10.2-7.6-1.5.2.jar --describe-module org.bytedeco.cuda
Error occurred during initialization of boot layer
java.lang.module.FindException: Error reading module: .\cuda-10.2-7.6-1.5.2.jar
Caused by: java.lang.module.InvalidModuleDescriptorException: Package org.bytedeco.cuda.npps not found in module

Fixed

> java -p .\cuda-10.2-7.6-1.5.4-SNAPSHOT.jar --describe-module org.bytedeco.cuda
org.bytedeco.cuda file:// ... /cuda-10.2-7.6-1.5.4-SNAPSHOT.jar
exports org.bytedeco.cuda.cublas
exports org.bytedeco.cuda.cudart
exports org.bytedeco.cuda.cudnn
exports org.bytedeco.cuda.cufftw
exports org.bytedeco.cuda.curand
exports org.bytedeco.cuda.cusolver
exports org.bytedeco.cuda.cusparse
exports org.bytedeco.cuda.global
exports org.bytedeco.cuda.nccl
exports org.bytedeco.cuda.nppc
exports org.bytedeco.cuda.nppicc
exports org.bytedeco.cuda.nppicom
exports org.bytedeco.cuda.nppig
exports org.bytedeco.cuda.nvgraph
exports org.bytedeco.cuda.nvml
exports org.bytedeco.cuda.nvrtc
exports org.bytedeco.cuda.presets
requires java.base mandated
requires org.bytedeco.javacpp transitive

Changes

  • Removed package exports

@saudet saudet requested a review from HGuillemet May 4, 2020 15:10
@HGuillemet
Copy link
Collaborator

Ok for me.
I'm reviewing all other presets for possible similar cases. I have already spotted one.
I will submit a PR for these other cases when I'm done.

@saudet saudet merged commit 6871d92 into bytedeco:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants