Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra "<p>" is generated for an empty line outside of comments #475

Closed
jpsacha opened this issue May 6, 2021 · 3 comments
Closed

Extra "<p>" is generated for an empty line outside of comments #475

jpsacha opened this issue May 6, 2021 · 3 comments
Labels

Comments

@jpsacha
Copy link
Member

jpsacha commented May 6, 2021

When parsing C++ source extra <p> is generated in Java code outside of the comments. A fragment of the source C++ code (including original indentation):

        /*@}*/
        /*@}*/

        /**
         *  @addtogroup Container_h Container Class
         */
        /*@{*/

        //*************************************************************
        // V A L U E _ V E C T O R
        //*************************************************************

        /**
         * @brief A vector of IValue pointers
         */
        class SPINNAKER_API value_vector

The Java code generated by JavaCPP (1.5.6-SNAPSHOT) resulted in:

        /*@}*/
        /*@}*/

        /**
         *  \addtogroup Container_h Container Class
         */
        /*@{*/

        //*************************************************************
        // V A L U E _ V E C T O R
        //*************************************************************
        <p>
        /**
         * \brief A vector of IValue pointers
         */
        @Namespace("Spinnaker::GenApi") @NoOffset @Properties(inherit = org.bytedeco.spinnaker.presets.Spinnaker.class)
public class value_vector extends Pointer {

Notice that there is extra <p> outside of the comments.

@saudet saudet added the bug label May 7, 2021
saudet added a commit that referenced this issue May 7, 2021
… part of documentation comments (issue #475)

 * Set `Pointer.maxPhysicalBytes` to `4 * Runtime.maxMemory()` by default as workaround for memory-mapped files, ZGC, etc (issue #468)
@saudet
Copy link
Member

saudet commented May 7, 2021

Fixed in commit 343045d. Thanks for reporting!

@jpsacha
Copy link
Member Author

jpsacha commented May 9, 2021

The fix works for me

@saudet
Copy link
Member

saudet commented Aug 3, 2021

Fix released in JavaCPP 1.5.6. Enjoy!

@saudet saudet closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants