Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unique_ptr return by value #353

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

GeekOffTheStreet
Copy link
Contributor

This is a change that addresses the issues we were having in issue #312.

@saudet
Copy link
Member

saudet commented Oct 24, 2019

I don't think we can use that in general... Is it the second const or the first const that matters though? The second one looks harmless enough.

@GeekOffTheStreet
Copy link
Contributor Author

Looks like just making the method const is sufficient (updated).

@saudet saudet merged commit 663aa55 into bytedeco:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants