Automatic Thread Detachment for Windows #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Default Behavior: vm->DetachCurrentThread() happens automatically when upon thread termination. Previously, a new thread was attached and detached per method call. NO_JNI_DETACH_THREAD retains its original behavior, although it is likely superfluous.
saudet
reviewed
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Default Behavior: vm->DetachCurrentThread() is called automatically when an attached native thread is terminated. Previously, a new thread was attached and detached per method call, creating memory pressure and increasing debugging complexity.
New behavior attaches the thread once, and relies on a static _declspec( thread ) object to detect thread termination.
NO_JNI_DETACH_THREAD retains its original behavior, although it is likely unnecessary.