Mark functions from c includes with noexception #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GCC doesn't do these kinds of optimization by default because we might have callbacks that throw C++ exceptions, but I think it's a good idea to offer the option to the user, and this looks like a good default. Could you only remove the '\n' and replace that with a white space like it's done for other annotations? And I'll merge that in. Thanks! |
This allows the Generator to avoid wrapping the function invocations with try/catch when no exception is possible
osialr
force-pushed
the
staging/mark-c-funcs-as-noexception
branch
from
33e1eda
to
9086541
Compare
|
Amended with your suggestions |
saudet
added a commit
that referenced
this pull request
Mar 13, 2016
* Annotate functions originating from `cinclude` with `@NoException`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Generator to avoid wrapping the function invocations with
try/catch when no exception is possible