Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct access to frame pict type in Frame Class #1730

Merged
merged 5 commits into from
Dec 13, 2021

Conversation

steeveen
Copy link
Contributor

@saudet
Copy link
Member

saudet commented Dec 11, 2021

Instead of using int or even enum, I was thinking we could just use char with as values I, P, B, and maybe others in the future. What do you think?

@steeveen
Copy link
Contributor Author

Not a big problem.
char seems to be better for readability
But I saw the type contains SI、SP、BI
image
Using String to represent them might be not a appropriate way.

@saudet
Copy link
Member

saudet commented Dec 11, 2021

Looks like FFmpeg itself is just using lowercase letters in that case:
https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/utils.c#L83-L95
So, let's just call av_get_picture_type_char() to get a char and put that in :)

@steeveen
Copy link
Contributor Author

OK,you are right. I have converted it ~

@saudet saudet merged commit d9a1ec5 into bytedeco:master Dec 13, 2021
anotherche pushed a commit to anotherche/javacv that referenced this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants