Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split stereo or merge monos helper #2052

Merged
merged 4 commits into from Jul 8, 2023
Merged

Split stereo or merge monos helper #2052

merged 4 commits into from Jul 8, 2023

Conversation

steeveen
Copy link
Contributor

@steeveen steeveen commented Jul 1, 2023

@saudet
Copy link
Member

saudet commented Jul 1, 2023

Thanks! Please fix it so it compiles when built from the command line with mvn clean compile:

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/saudet/projects/bytedeco/javacv/samples/SplitMerge.java:[35,8] class AduioSplitMergeHelper is public, should be declared in a file named AduioSplitMergeHelper.java
[ERROR] /home/saudet/projects/bytedeco/javacv/samples/SplitMerge.java:[1,27] package lombok.extern.slf4j does not exist
[ERROR] /home/saudet/projects/bytedeco/javacv/samples/SplitMerge.java:[3,17] package org.junit does not exist
[ERROR] /home/saudet/projects/bytedeco/javacv/samples/SplitMerge.java:[34,2] cannot find symbol
  symbol: class Slf4j
[INFO] 4 errors

@steeveen
Copy link
Contributor Author

steeveen commented Jul 1, 2023

Sorry. I forget remove the test tag. I have fixed it.

@steeveen
Copy link
Contributor Author

steeveen commented Jul 3, 2023

Ok, I have commited all the change

saudet
saudet approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@saudet saudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the contribution

@saudet saudet merged commit dba789d into bytedeco:master Jul 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudet saudet saudet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steeveen @saudet