Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bminstall script for mac #50

Closed

Conversation

rafaelnferreira
Copy link

Hello, an amendment has been made on the bminstall.sh script which was not anymore compatible with current OS. By testing with Jdks from 1.6 to 1.8 I could not understand why a switch was introduced in an attempt to load Classes.jar (maybe that was the case in really old jdk releases prior to 1.6).

My reference installation structure for the test:

ls /Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home/
bin bundle lib man

ls /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/
COPYRIGHT THIRDPARTYLICENSEREADME-JAVAFX.txt db lib src.zip
LICENSE THIRDPARTYLICENSEREADME.txt include man
README.html bin jre release

ls /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/
COPYRIGHT THIRDPARTYLICENSEREADME-JAVAFX.txt db jre release
LICENSE THIRDPARTYLICENSEREADME.txt include lib src.zip
README.html bin javafx-src.zip man

@adinn
Copy link
Member

adinn commented Aug 3, 2016

Hi rafael,

I'm not sure exactly what this pull request is meant to do. The script attempts to make sure that classes needed for the install operation to work are available in the classpath. These classes were in classes.jar on releases of Java for Mac where the script was tested. If your release does not contain that jar then it will still need these classes to be available in order for the script to work.

Are you suggesting that all current releases of Java for Mac have relocated these classes to another jar? If so then can you please identify for me where your release provides class com.sun.tools.attach.VirtualMachine.

If your release does not contain these classes then that may well be because it is a JRE release (i.e. a Java runtime) rather than a full JDK release (i.e. a development release). You need a full JDK release in order to be able to use the install script.

@adinn
Copy link
Member

adinn commented Oct 17, 2016

I cannot proceed with this pull without further input. Given the lack of any response I am rejecting it.

@adinn adinn closed this Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants