Post code showcasing in/complete formula differences

[bytemare]

This code shows differences in this implementation of outputs from complete and incomplete add and double on Secp256k1.

The incomplete formula is taken from: http://hyperelliptic.org/EFD/g1p/auto-shortw-jacobian-0.html#addition-add-2007-bl

The complete formula is taken from: https://eprint.iacr.org/2015/1060.pdf

Go to internal/secp256k1 and run go test for the demo.

[codecov]

Codecov Report

Merging #38 (a6ca0a9) into main (b866f41) will decrease coverage by 7.07%.
The diff coverage is 67.54%.

❗ Current head a6ca0a9 differs from pull request most recent head e4201d7. Consider uploading reports for the commit e4201d7 to get more accurate results

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   81.47%   74.41%   -7.07%     
==========================================
  Files          16       22       +6     
  Lines         934     1501     +567     
==========================================
+ Hits          761     1117     +356     
- Misses        112      304     +192     
- Partials       61       80      +19     

Impacted Files	Coverage Δ
element.go	82.05% <ø> (+2.56%)	⬆️
internal/edwards25519/element.go	78.18% <ø> (ø)
internal/edwards25519/group.go	90.90% <ø> (ø)
internal/edwards25519/scalar.go	80.00% <ø> (ø)
internal/misc.go	50.00% <ø> (ø)
internal/ristretto/element.go	79.66% <ø> (ø)
internal/ristretto/ristretto.go	76.92% <ø> (ø)
internal/ristretto/scalar.go	84.55% <ø> (ø)
internal/secp256k1/secp256k1_export.go	0.00% <0.00%> (ø)
scalar.go	79.59% <ø> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

100.0% Coverage
0.0% Duplication

[gitguardian]

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
6384938	Generic High Entropy Secret	9eaf712	internal/secp256k1/secp256k1_export.go	View secret
6384938	Generic High Entropy Secret	c64fa72	internal/secp256k1/secp256k1_export.go	View secret
6384938	Generic High Entropy Secret	11c69c1	internal/secp256k1/secp256k1_export.go	View secret
6384938	Generic High Entropy Secret	e4201d7	internal/secp256k1/secp256k1_export.go	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

<sup>🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!</sup>