Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some dependencies and use scalarbasemult for nist curves when posssible #43

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

bytemare
Copy link
Owner

No description provided.

…posssible

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (b866f41) 81.47% compared to head (55b926d) 78.98%.
Report is 9 commits behind head on main.

Files Patch % Lines
internal/field/field.go 50.81% 29 Missing and 1 partial ⚠️
internal/secp256k1/scalar.go 76.27% 8 Missing and 6 partials ⚠️
internal/nist/element.go 69.23% 6 Missing and 2 partials ⚠️
internal/edwards25519/map.go 66.66% 2 Missing and 2 partials ⚠️
internal/nist/group.go 75.00% 3 Missing ⚠️
internal/nist/scalar.go 88.46% 2 Missing and 1 partial ⚠️
internal/secp256k1/element.go 92.10% 2 Missing and 1 partial ⚠️
groups.go 50.00% 2 Missing ⚠️
internal/secp256k1/group.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   81.47%   78.98%   -2.50%     
==========================================
  Files          16       19       +3     
  Lines         934     1066     +132     
==========================================
+ Hits          761      842      +81     
- Misses        112      154      +42     
- Partials       61       70       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Signed-off-by: bytemare <3641580+bytemare@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bytemare bytemare merged commit 88de307 into main Nov 27, 2023
7 of 10 checks passed
@bytemare bytemare deleted the update-deps branch November 27, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant