Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pysftp walktree method missing for drop in replacement #49

Closed
hulleyrob opened this issue Jun 3, 2024 · 2 comments · Fixed by #51
Closed

pysftp walktree method missing for drop in replacement #49

hulleyrob opened this issue Jun 3, 2024 · 2 comments · Fixed by #51
Assignees
Labels
question Further information is requested

Comments

@hulleyrob
Copy link

Was this for performance reasons and wont be getting added in the future?

Only asking as im currently converting a script that used it after updating a Catalina based Mac that finally broke and wont connect anymore. Sftpretty is working on the machine but need to covert the rest of the code over.

@hulleyrob
Copy link
Author

actually looking at the code not even sure what that was being used for have replaced with listdir and replaced get_d with get_r and it all seems to work. Its more that someone might be looking for an exact drop in replacement so not expecting it to be added.

@byteskeptical byteskeptical self-assigned this Jun 3, 2024
@byteskeptical byteskeptical added the question Further information is requested label Jun 3, 2024
@byteskeptical
Copy link
Owner

byteskeptical commented Jun 3, 2024

That's fair and that verbage is probably overdue for an update. Walktree performance didn't scale well at larger directory sizes and manipulating the resulting object could be another expensive operation. Without prior directory knowledge one could easily end up with duplicate entries requiring additional sanitization step(s). Lastly, using a single list object once ThreadPool was introduced wasn't a good fit in general. Let me know if you run any into additional cases in your switch and thanks for using the library!

@byteskeptical byteskeptical linked a pull request Jun 20, 2024 that will close this issue
@byteskeptical byteskeptical linked a pull request Jun 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants