Restructure Python imports #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses `__all__` to provide an explicit index of the package when doing `from bytewax import *`.
davidselassie
approved these changes
Feb 24, 2022
pysrc/bytewax/__init__.py
Outdated
|
|
||
| from .execution import run, spawn_cluster, run_cluster | ||
|
|
||
| __all__ = [ |
There was a problem hiding this comment.
I'm not super familiar with this. Is there a specific behavior you're hoping to cause or prevent with __all__? Otherwise isn't importing a symbol into __init__.py enough to cause it to be included in from bytewax import *?
There was a problem hiding this comment.
You are correct in that importing a symbol into __init__.py is enough to include it. I was attempting to carve out a few of the parts of our public API that were pulled in, like _run, but I just tested it and it didn't end up working anyway.
I think on closer inspection, I should skip using __all__. I'll update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__all__to provide an explicit index of the packagewhen doingfrom bytewax import *.