Add windows build support #249
Conversation
.github/workflows/windows.yml
Outdated
| @@ -0,0 +1,31 @@ | |||
| name: WINTEST | |||
| on: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Since this workflow is configured to run on the workflow_dispatch event, we won't be able to run it, as workflow_dispatch events can only be triggered if they are present in the main branch of the repository.
I think it would be a good idea to add this build to .github/workflows/CI.yml, so we can try building it and running the test suite for windows.
There was a problem hiding this comment.
workflow_dispatch is only for testing purposes, after all, windows build requires a special environment.
Another reason for providing the windows.yml file is that I can't build the sasl2-sys library locally, but github action can, so maybe I'm missing some necessary build dependencies.
I also think it is a good idea to merge that workflow into CI.
.github/workflows/windows.yml
Outdated
| - build: windows-vendored | ||
| os: windows-latest | ||
| rust: stable | ||
| features: vendored,openssl-vendored |
There was a problem hiding this comment.
Are these matrix features used? I don't see them referenced in this action.
There was a problem hiding this comment.
These matrix features are a direct use of rust-sasl's workflow, and perhaps we can do some optimization of this
https://github.com/MaterializeInc/rust-sasl/blob/master/.github/workflows/main.yml
| [target.'cfg(target_os = "windows")'.dependencies] | ||
| sasl2-sys = {version="0.1.20",features=["vendored","openssl-vendored"]} | ||
|
|
||
| [build-dependencies] |
There was a problem hiding this comment.
Should this also be conditionally set for windows builds?
There was a problem hiding this comment.
Based on these issues, it can be determined that the force-engine feature is required for windows and musl platforms
fede1024/rust-rdkafka#572 (comment)
fede1024/rust-rdkafka#446
alexcrichton/openssl-src-rs#151
|
/cc #248 |
|
@whoahbot |
|
@whoahbot fixed test_cluster_can_be_ctrl_c in windows |
|
@zzl221000 Thanks for putting this PR together. I need to change one more thing in the CI/CD workflow in order to publish this version to PyPI. I'll make that change in a subsequent PR when we create the next release. |
Add the vendored feature of sasl2-sys library