Debug operators #29
Debug operators #29
Conversation
| fn type_name_of<T>(_: T) -> &'static str { | ||
| std::any::type_name::<T>() | ||
| } | ||
| let name = type_name_of(f); |
There was a problem hiding this comment.
It looks like the goal of this macro is to get the name of the containing function? How does this work?
There was a problem hiding this comment.
That is the goal although the rust function isn't as precise as I'd like.
There was a problem hiding this comment.
As in, does this print out the name of this function f() instead of the calling function like map()? Or does that somehow access the calling function? Or is this a kind of hack where f() has a fully qualified name like bytewax::map::f() and so we get access to the enclosing function? I'd like to understand how this works.
There was a problem hiding this comment.
Candidly, the internet helped me with this, but I believe you can wrap the function in your own code and thereby access the type of the function which resolves to the fully qualified name.
There was a problem hiding this comment.
I think that makes sense. Hence the slice to -3 to remove f() as the last step.
|
|
||
| // These are all shims which map the Timely Rust API into equivalent | ||
| // calls to Python functions through PyO3. | ||
|
|
||
| pub(crate) fn map(mapper: &TdPyCallable, item: TdPyAny) -> TdPyAny { | ||
| debug!("{}, mapper:{:?}, item:{:?}", log_func!(), mapper, item); |
There was a problem hiding this comment.
It would be nice to log out epoch as well in all of these so you can flip a single logging switch and see a complete trace of execution. But that would be a bigger change because it would require changing the Timely operators we use and re-jiggering some of the shim functions, so I don't think we need to do it now. Just a note for posterity!
| fn type_name_of<T>(_: T) -> &'static str { | ||
| std::any::type_name::<T>() | ||
| } | ||
| let name = type_name_of(f); |
There was a problem hiding this comment.
As in, does this print out the name of this function f() instead of the calling function like map()? Or does that somehow access the calling function? Or is this a kind of hack where f() has a fully qualified name like bytewax::map::f() and so we get access to the enclosing function? I'd like to understand how this works.
First pass adding some debugging to our operators.