merge prototype updates #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets you use `?` within the PyO3-using code and get tracebacks for all the errors within. Does this by putting the calling expression in a closure and then immediately calls it. One day we could use https://doc.rust-lang.org/nightly/unstable-book/language-features/try-blocks.html Cleans up all the `with_traceback!` use sites and adds some I missed.
Does some Maturin boilerplate to allow us to have a mixed Python / Rust package. Adds an `inp` package with three helpers: 1. `single_batch` to put all your data in the same epoch 2. `tumbling_epoch` to open a new epoch every some number of seconds 3. `fully_ordered` which opens a new epoch per item Updates the examples to use these. Runs formatter on all the Python files. Kills the stateful example because it's not right anyway. New version forthcoming.
Turns out both `Py` and `PyAny`'s impl of `eq` just compare pointers. So the previous code didn't actually look at the Python values. I think it "worked" because CPython does int and string interning so the actual objects would be identical. It stopped working when I started needing to clone values for some of my further experimentation. This uses `PyAny.rich_compare` to call out to Python's `__eq__` and friends for equality.
whoahbot
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes missed changes from prototype repo.