Prepare for v0.19.0 release #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #423 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Added some explanatory notes. I also think we should break out the datetime changes to be more explicit.
I might have messed up on some of the xrefs since I'm writing them off the cuff, but https://docs.bytewax.io/stable/articles/contributing/writing-docs.html#finding-reference-names will help to find them.
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
Co-authored-by: David Selassie <david@bytewax.io> Signed-off-by: Dan Herrera <whoahbot@gmail.com>
whoahbot
force-pushed
the
prepare_0.19.0
branch
from
0ee25be
to
f076247
Compare
whoahbot
force-pushed
the
prepare_0.19.0
branch
from
f076247
to
0cc375f
Compare
davidselassie
approved these changes
Mar 20, 2024
| def build(self, now: datetime, worker_index: int, worker_count: int): | ||
| pass | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Suggested change
| After: | |
Psykopear
reviewed
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.