Benchmarks #7
Merged
Benchmarks #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `execute_directly()` to `Executor` to specify a number of threads to run on. - Adds criterion library
davidselassie
approved these changes
Feb 9, 2022
| def acc(word_to_count, words): | ||
| for word in words: | ||
| if word not in word_to_count: | ||
| word_to_count[word] = 0 |
There was a problem hiding this comment.
Should be able to drop this if since that's what defaultdict does.
There was a problem hiding this comment.
Good catch, thanks!
| exec = bytewax.Executor() | ||
| flow = exec.Dataflow(file_input()) | ||
| flow.flat_map(tokenize) | ||
| flow.accumulate(lambda: defaultdict(int), acc) |
There was a problem hiding this comment.
I'm actually curious what changing this to reduce_epoch does to performance since we're leaning more on Rust code to do the grouping and collecting, but there's more back and forth between Py-Rust.
There was a problem hiding this comment.
Agreed! I'll let you know what I find out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the framework for a benchmarking suite. The benchmark that is in this PR is just intended as an example of benchmarking Python vs Bytewax, and should be replaced with a suitable example.
Running the benchmarks
Running
cargo benchnormally will result in linker errors due to this issue, so to run the benchmarks, use:execute_directly()toExecutorto specify a number of threads to run on.