Fixes and improvements #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `open` to the Styled component doesn't refresh the `transform` CSS property. Resolves: Issue byteyilabs#106
…name Transforms `(123) My super video - YouTube` into just `My super video`
Also fixes exporting markdown files with links without the video ID nor the `t=` query param.
This was referenced Aug 4, 2022
Closed
hh23485
reviewed
Sep 19, 2022
| // Removing notifications count and " - Youtube" at the end | ||
| const fileName = meta.title | ||
| .replace(/^\(.*\) /g, '') | ||
| .replace(/ - YouTube$/g, ''); |
There was a problem hiding this comment.
I think you removed yinote_ prefix, is there a strong reason to do this? @lemattma
Sacmanxman2
pushed a commit
to Sacmanxman2/yi-note
that referenced
this pull request
Feb 12, 2024
Added the yinote prefix to the fileName constant, resolving feedback on byteyilabs#113
Open
shuowu
approved these changes
Feb 18, 2024
|
@lemattma Thanks for fixing the issue! FYI, due to recent acquisition from ByteYi Labs, we have moved main logic from this repo to another monorepo (private) for easier maintenance reason. Code in this codebase may become inconsistent with the released version from chrome / edge web stores in the future. For this issue, I also released a fix in v1.8.0 (in pending store review) with shadow-dom, hopefully it can help avoid future host page style updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes:
fromStringerrorSorry that I'm adding all of this in one PR. I've added separate commits for each fix.
I love this extension!
Thanks @shuowu