Skip to content

Commit

Permalink
Merge pull request #73 from byu-oit/s3-acl
Browse files Browse the repository at this point in the history
Don't create ACL. It doesn't work anymore.
  • Loading branch information
joshgubler committed Apr 25, 2023
2 parents 10c5b2d + ac29b0f commit 94d6ad1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This lambda function will tell CodeDeploy if the tests pass or fail.

```hcl
module "postman_test_lambda" {
source = "github.com/byu-oit/terraform-aws-postman-test-lambda?ref=v5.0.2"
source = "github.com/byu-oit/terraform-aws-postman-test-lambda?ref=v5.0.3"
app_name = "simple-example"
postman_collections = [
{
Expand Down Expand Up @@ -85,7 +85,7 @@ selecting your collection/environment and clicking on the info icon.

```hcl
module "postman_test_lambda" {
source = "github.com/byu-oit/terraform-aws-postman-test-lambda?ref=v5.0.2"
source = "github.com/byu-oit/terraform-aws-postman-test-lambda?ref=v5.0.3"
app_name = "from-postman-api-example"
postman_collections = [
{
Expand Down
6 changes: 0 additions & 6 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,6 @@ resource "aws_s3_bucket" "postman_bucket_logs" {
tags = var.tags
}

resource "aws_s3_bucket_acl" "postman_bucket_logs" {
count = local.using_local_files ? 1 : 0
bucket = aws_s3_bucket.postman_bucket_logs[count.index].id
acl = "log-delivery-write"
}

resource "aws_s3_bucket_lifecycle_configuration" "postman_bucket_logs" {
count = local.using_local_files ? 1 : 0
bucket = aws_s3_bucket.postman_bucket_logs[count.index].id
Expand Down

0 comments on commit 94d6ad1

Please sign in to comment.