Skip to content

Commit

Permalink
test: node upgrade to 20
Browse files Browse the repository at this point in the history
  • Loading branch information
chlohilt committed May 16, 2024
1 parent fab7996 commit 1e426d5
Show file tree
Hide file tree
Showing 13 changed files with 977 additions and 669 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
concurrency: ${{ github.ref }}
env:
tf_version: "1.4.5" # must match value in terraform-iac/*/app/main.tf
node_version: "16.x" # must match value in log-analyzer/sorter-lambda/package.json
node_version: "20.x" # must match value in log-analyzer/sorter-lambda/package.json

jobs:
env:
Expand Down
2 changes: 1 addition & 1 deletion assembler/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM public.ecr.aws/docker/library/node:18-alpine
FROM public.ecr.aws/docker/library/node:20-alpine

## Install python (for AWS CLI) and git
RUN apk --no-cache add python3 git
Expand Down
662 changes: 5 additions & 657 deletions assembler/package-lock.json

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions assembler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"test": "mocha --recursive"
},
"engines": {
"node": ">=14.0.0",
"node": ">=20.0.0",
"npm": ">=6.0.0"
},
"author": "",
Expand Down Expand Up @@ -52,7 +52,6 @@
},
"devDependencies": {
"array-equal": "^1.0.0",
"babel-preset-es2016-node4": "^6.0.1",
"chai": "^3.5.0",
"chai-as-promised": "^6.0.0",
"mocha": "^10.2.0",
Expand Down
2 changes: 1 addition & 1 deletion iac/modules/app/eager-redirect.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ resource "aws_lambda_function" "eager_redirect_func" {
function_name = "${local.app_name}-edge-eager-redirect"
filename = data.archive_file.eager_redirect_func.output_path
handler = "index.handler"
runtime = "nodejs16.x"
runtime = "nodejs20.x"
memory_size = 512
timeout = 20
role = aws_iam_role.edge_lambda_execution_role.arn
Expand Down
2 changes: 1 addition & 1 deletion iac/modules/app/enhanced-headers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ resource "aws_lambda_function" "enhanced_headers_func" {
function_name = "${local.app_name}-edge-enhanced-headers"
filename = data.archive_file.enhanced_header_func.output_path
handler = "index.handler"
runtime = "nodejs16.x"
runtime = "nodejs20.x"
memory_size = 128
timeout = 20
role = aws_iam_role.edge_lambda_execution_role.arn
Expand Down
Loading

0 comments on commit 1e426d5

Please sign in to comment.