Fix PHP notice with PHP > 5.5 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I must have missed that. Can you please also fix the corresponding test? :-) |
CN_match is deprecated in PHP 5.6 - peer_name should be used instead.
|
The inspection completed: No new issues |
|
Seems like the automatic test pipeline failed (with a timeout?) for PHP 7.3. There have been no changes since the last successful run, i just squashed the 2 commits. |
|
It does sometimes timeout; I restarted the job and will merge on success. Thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CN_match is deprecated in PHP 5.6 - peer_name should be used instead. From 5.6. the SNI options + the additional hostname for "verifyPeer" are somewhat redundant, but left it in for now to support PHP < 5.6 with the old constant name "CN_match".