Fix #151 make gelf php compatible with psr log 1.0 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration Fixes bzikarsky#151 This patch makes the component compatible with `psr/log:^1` again. Ref: bzikarsky#151 > Heyo, just noticed this incompatibility while upgrading: > > ``` > PHP Fatal error: Declaration of Gelf\Logger::log($level, Stringable|string $message, array $context = []): void must be compatible with Psr\Log\LoggerInterface::log($level, $message, array $context = []) > ``` > > Practically, the `Stringable|string` is incompatible with `Psrl\Log\LoggerInterface` in `psr/log:1.0.0`: > > https://github.com/php-fig/log/blob/fe0936ee26643249e916849d48e3a51d5f5e278b/Psr/Log/LoggerInterface.php#L113 > > ``` > /** > * Logs with an arbitrary level. > * > * @param mixed $level > * @param string $message > * @param array $context > * @return null > */ > public function log($level, $message, array $context = array()); > ``` > > https://github.com/bzikarsky/gelf-php/blob/a8f68846ff4db5f1942172bb428465be7ebb768c/src/Gelf/Logger.php#L42-L44 Ref: https://wiki.php.net/rfc/covariant-returns-and-contravariant-parameters
|
Thanks! 😊 |
|
Tagged 2.0.1 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
This patch is targeting
master, but is aimed at2.0.1(to be released as a patch).Also very happy to send a follow-up after a
2.0.1release, to droppsr/log:^1support, and re-introduce the type declarations :-)