Remove none existing null handling in UdpTransport #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading from version 1.6.4 to 2.0.1 we got a crash because of a passed null host value to the
UdpTransportclass in a pipeline, which was an unexpected break but obviously not unknown when types are introduced.When looking at the class I noticed the null comments and checks were still in place which this PR intends to fix. I realized the two checks should stay because they are still checking for empty strings.
The MR ended up being very minor but fixing some more none strict checks which are safe because the type is given. Feel free to merge or (partly) take into any other commit.