-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL support for HTTP transport #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7018c5c
to
2ebdf48
Compare
bzikarsky
pushed a commit
that referenced
this pull request
Oct 19, 2014
bzikarsky
pushed a commit
that referenced
this pull request
Oct 19, 2014
b005f52
to
69414c1
Compare
bzikarsky
pushed a commit
that referenced
this pull request
Oct 20, 2014
bzikarsky
pushed a commit
that referenced
this pull request
Oct 20, 2014
The inspection completed: 12 updated code elements |
d25a288
to
acfc275
Compare
bzikarsky
pushed a commit
that referenced
this pull request
Mar 9, 2015
bzikarsky
pushed a commit
that referenced
this pull request
Mar 9, 2015
480aa27
to
b5333ff
Compare
bzikarsky
pushed a commit
that referenced
this pull request
Mar 9, 2015
SSL support for HTTP transport #24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current HTTP transport implementation (see #6, #19) lacks support for SSL/TLS. Some real basic ideas can be taken from the old #6-implementation branch in https://github.com/bzikarsky/gelf-php/blob/issues/6-http-transport/src/Gelf/Transport/HttpTransport.php
Since this is rather big issue, I converted the issue to an internal PR with a custom branch. Please contribute by opening PRs on this branch instead of master.
/cc @steffkes
Tasks
StreamSocketClient
with support for stream-contextStreamSocketClient
class Gelf\Transport\SslOptions
) + tests; possibly relevant options are:verify_peer
- default totrue
allow_self_signed
- default tofalse
cafile
- lots of people with a custom CA...we also need this for testingciphers
- Allows us to disable certain ciphers, such as SSLv3 (...Poodle-Attack)SNI_enabled
andSNI_server_name
) when available (OpenSSL 0.9.8j+)CN_match
on Hostname