Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support for HTTP transport #24

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Conversation

bzikarsky
Copy link
Owner

Issue

The current HTTP transport implementation (see #6, #19) lacks support for SSL/TLS. Some real basic ideas can be taken from the old #6-implementation branch in https://github.com/bzikarsky/gelf-php/blob/issues/6-http-transport/src/Gelf/Transport/HttpTransport.php

Since this is rather big issue, I converted the issue to an internal PR with a custom branch. Please contribute by opening PRs on this branch instead of master.

/cc @steffkes

Tasks

  • Extend StreamSocketClient with support for stream-context
  • Tests for stream-context-support in StreamSocketClient
  • Abstraction for SSL-options (class Gelf\Transport\SslOptions) + tests; possibly relevant options are:
    • verify_peer - default to true
    • allow_self_signed - default to false
    • cafile - lots of people with a custom CA...we also need this for testing
    • ciphers - Allows us to disable certain ciphers, such as SSLv3 (...Poodle-Attack)
  • Extend HttpTransport with a SslOptions parameter, when NULL (default) is passed, no SSL is used
  • Enable SNI (SNI_enabled and SNI_server_name) when available (OpenSSL 0.9.8j+)
  • Enable CN_match on Hostname
  • Extend HttpTransportTests with checks for a correct scheme and context generation depending on $sslOptions

@scrutinizer-notifier
Copy link

The inspection completed: 12 updated code elements

bzikarsky pushed a commit that referenced this pull request Mar 9, 2015
SSL support for HTTP transport #24
@bzikarsky bzikarsky merged commit 6e71348 into master Mar 9, 2015
@bzikarsky bzikarsky deleted the issues/24-https-support branch March 9, 2015 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants