Ability to specify socket scheme in TcpTransport

[0livier]

This can be useful if there's no HTTPS support and when you have to use a ssl scheme (e.g. OVH's Graylog only allows TCP, UDP, TCP/ssl and not HTTPS https://docs.ovh.com/gb/en/mobile-hosting/logs-data-platform/quick-start/#id2)

[scrutinizer-notifier]

The inspection completed: No new issues

[bzikarsky]

While I understand your problem, I disagree with your solution. A scheme option on a TcpTransport doesn't make sense. StreamSocketClient is the scheme-generic implementation.

Also ususally it's not enough to slap on "ssl" to the connection string. You probably need to provide options for self-signed certs, etc.

Therefore I see two possible ways to tackle your problem:

1. Create a EncryptedTcpTransport (simple, but a little "dirty")
   Just create a custom class, utilize StreamSocketTransport, etc. You can even do this isolated in your project.

2. Pull down SslOptions from HttpTransport to TcpTransport (complex, but proper)
   There is already an SSL option class in this project. It shoulod be straightforward to port this over to TcpTransport.

[toubsen]

Needed / Wanted the same functionality, for privacy compliant submission of GELF messages to OVH Logs platform.

After trying the same native patch with a scheme parameter, found this issue and agree that option 2 with ported SslOptions is the best solution.

I took the time to port the code from HttpTransport to TcpTransport and created the new pull request #101

[bzikarsky]

Closed in favour of #101 - Thanks everyone