Add template to config, change to mustache logic-less templates #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version: 0.8.2 tag: Added
bzumhagen
reviewed
Dec 1, 2017
| @@ -14,7 +14,7 @@ object ChangelogConfiguration { | |||
| referencePattern = config.getString("sct.patterns.reference").r, | |||
| tags = config.getStringList("sct.tags").asScala.toSet, | |||
| smartGrouping = config.getBoolean("sct.smartGrouping"), | |||
| showReference = config.getBoolean("sct.showReference") | |||
There was a problem hiding this comment.
I think we should maintain showreference option, for example if exposing to customers they aren't going to care about the ticket reference to our internal system which they don't have access to.
There was a problem hiding this comment.
good point, I'll bring it back
bzumhagen
reviewed
Dec 1, 2017
build.sbt
Outdated
| @@ -2,7 +2,7 @@ name := "sct" | |||
|
|
|||
| organization := "com.github.bzumhagen" | |||
|
|
|||
| version := "0.8.1" | |||
| version := "0.8.2" | |||
There was a problem hiding this comment.
I think it's a big enough change to increment minor version to 0.9.0
bzumhagen
requested changes
Dec 1, 2017
bzumhagen
reviewed
Dec 2, 2017
uyushkevich-zz
force-pushed
the
master
branch
from
6711e65
to
760b0ad
Compare
|
well, had bad experience with amend commit, hope it's better this time |
version: 0.9.0 tag: Added
uyushkevich-zz
force-pushed
the
master
branch
from
760b0ad
to
de1b026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version: 0.8.2
tag: Added