pthreads related build error in SLES 11 for version 1.23.0 (PTHREAD_MUTEX_RECURSIVE and pthread_mutexattr_settype undeclared)

[rainerjung]

On SLES 11 file src/lib/ares__threads.c does not compile for version 1.23.0:

ares__threads.c: In function 'ares__thread_mutex_create':
ares__threads.c:94: warning: implicit declaration of function 'pthread_mutexattr_settype'
ares__threads.c:94: warning: nested extern declaration of 'pthread_mutexattr_settype'
ares__threads.c:94: error: 'PTHREAD_MUTEX_RECURSIVE' undeclared (first use in this function)
ares__threads.c:94: error: (Each undeclared identifier is reported only once
ares__threads.c:94: error: for each function it appears in.)

Although pthread.h is included, it seems for such old Linux version one needs to either define _GNU_SOURCE or _XOPEN_SOURCE 700. For me it was sufficient to do that in ares__threads.c.

[bradh352]

I assuming you're using autotools and not cmake then? I'm showing with CMake at least _GNU_SOURCE is defined. And does it really need _XOPEN_SOURCE=700? Looks like we're setting 600.

[rainerjung]

Thank you for fixing this. Yes, I used configure and make, so the autotools generated files from the source tarball. I did not regenerate those.