Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: lower required version to 2.8.12 #306

Closed
wants to merge 1 commit into from

Conversation

sergepetrenko
Copy link

@sergepetrenko sergepetrenko commented Mar 3, 2020

There is no need to require CMake version >= 3.1.0
CMake 2.8.12 shipped with CentOS 6 and CentOS 7 still works just fine, as can be checked here:
https://gitlab.com/tarantool/tarantool/-/jobs/410010014 (We use cmake to build ares as part of tarantool. Search for lines containing bundled-ares-project)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 89.364% when pulling bbbffa4 on tarantool:tarantool into 287bde0 on c-ares:master.

@bradh352
Copy link
Member

bradh352 commented Mar 4, 2020

I'm pretty sure there are significant issues on other platforms if trying to use cmake 2.8. So while it might be ok on linux, I'm pretty sure that's not the case on Windows and possibly MacOS. I don't have any interest in trying to support a long EOL version of CMake, even if it is the default on CentOS7 ... EPEL has had cmake3 forever ...

@bradh352 bradh352 closed this Mar 4, 2020
@Totktonada
Copy link

We didn't expirienced any build problems on Linux, Mac OS and FreeBSD. We don't support Windows, however.

It is okay for us to keep the lower cmake version requirement within our fork, so please consider this PR as 'we tried cmake 2.8 on various platforms and everything works'. If there are known problems on, say, Windows, I understood your point.

Our motivation is to keep cmake 2.8 is to simplify build for a user / a distro maintainer: cmake 2.8 is available in system repositories on all distros / OSes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants