autotools: fix building for 32bit windows due to stdcall symbol mangling #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradh352
added a commit
that referenced
this pull request
Jan 16, 2024
…ing (#689) Use AC_CHECK_DECL not AC_CHECK_FUNCS, while this doesn't do a linkage test, it just makes sure the headers define it, this is the only thing without a complex workaround on Windows that will do what we need. See: https://github.com/msys2/msys2/wiki/Porting/f87a222118b1008ebc166ad237f04edb759c8f4c#calling-conventions-stdcall-and-autotools and https://lists.gnu.org/archive/html/autoconf/2013-05/msg00085.html and for a more complex workaround, we'd need to use AC_LINK_IFELSE like: https://mailman.videolan.org/pipermail/vlc-devel/2015-March/101802.html which would require we check each individually and provide function arguments for the test. I don't think that is worthwhile. Fixes Issue: #688 Fix By: Brad House (@bradh352)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 28, 2024
## c-ares version 1.26.0 - Jan 26 2024 Features: * Event Thread support. Integrators are no longer requried to monitor the file descriptors registered by c-ares for events and call `ares_process()` when enabling the event thread feature via `ARES_OPT_EVENT_THREAD` passed to `ares_init_options()`. [PR #696](c-ares/c-ares#696) * Added flags to `are_dns_parse()` to force RAW packet parsing. [PR #693](c-ares/c-ares#693) Changes: * Mark `ares_fds()` as deprected. [PR #691](c-ares/c-ares#691) Bugfixes: * `adig`: Differentiate between internal and server errors. [e10b16a](c-ares/c-ares@e10b16a) * Autotools allow make to override CFLAGS/CPPFLAGS/CXXFLAGS. [PR #695](c-ares/c-ares#695) * Autotools: fix building for 32bit windows due to stdcall symbol mangling. [PR #689](c-ares/c-ares#689) * RR Name should not be sanity checked against the Question. [PR #685](c-ares/c-ares#685)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use AC_CHECK_DECL not AC_CHECK_FUNCS, while this doesn't do a linkage test, it just makes sure the headers define it, this is the only thing without a complex workaround on Windows that will do what we need.
See:
https://github.com/msys2/msys2/wiki/Porting/f87a222118b1008ebc166ad237f04edb759c8f4c#calling-conventions-stdcall-and-autotools
and
https://lists.gnu.org/archive/html/autoconf/2013-05/msg00085.html
and for a more complex workaround, we'd need to use AC_LINK_IFELSE like:
https://mailman.videolan.org/pipermail/vlc-devel/2015-March/101802.html
which would require we check each individually and provide function arguments for the test. I don't think that is worthwhile.
Fixes Issue: #688
Fix By: Brad House (@bradh352)