Fix warning about ignoring result of write #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the compiler warning from clang:
```
ares_event_wake_pipe.c:120:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
120 | write(p->filedes[1], "1", 1);
| ^~~~~ ~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Feb 7, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709
bradh352
pushed a commit
that referenced
this pull request
Feb 8, 2024
Fix the compiler warning from clang:
```
ares_event_wake_pipe.c:120:3: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
120 | write(p->filedes[1], "1", 1);
| ^~~~~ ~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
Fix By: Cheng Zhao (@zcbenz)
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Feb 21, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Feb 21, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Feb 21, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709
zcbenz
added a commit
to zcbenz/node
that referenced
this pull request
Feb 23, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709
zcbenz
added a commit
to nodejs/node
that referenced
this pull request
Feb 23, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 26, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 26, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
marco-ippolito
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 27, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
richardlau
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 25, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
richardlau
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 25, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: #51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This change can be removed after the upstream fix lands in Node: c-ares/c-ares#709 PR-URL: nodejs#51687 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the compiler warning from clang: