Merged
Conversation
ClifHouck
added a commit
to ClifHouck/envoy
that referenced
this pull request
Mar 3, 2025
In version 1.31.0 c-ares enabled its query cache feature by default. See c-ares/c-ares#786 . This subverted test expectations that each query would be run in the same way. This commit turns it off again in the c-ares dns impl by default. Adds a test to check that query cache is indeed off. Adds a bit of addtional safety around handling TTLs in c-ares dns impl and test code. In PendingTimerEnable test a resolver address is now passed, otherwise c-ares returns an error immediately. The number of expected timeouts is also different because starting in version 1.32.0 c-ares now manages it's own timeout expectations past the first timeout. See c-ares/c-ares#794 Signed-off-by: Clif Houck <me@clifhouck.com>
ClifHouck
added a commit
to ClifHouck/envoy
that referenced
this pull request
Mar 3, 2025
In version 1.31.0 c-ares enabled its query cache feature by default. See c-ares/c-ares#786 . This subverted test expectations that each query would be run in the same way. This commit turns it off again in the c-ares dns impl by default. Adds a test to check that query cache is indeed off. Adds a bit of addtional safety around handling TTLs in c-ares dns impl and test code. In PendingTimerEnable test a resolver address is now passed, otherwise c-ares returns an error immediately. The number of expected timeouts is also different because starting in version 1.32.0 c-ares now manages it's own timeout expectations past the first timeout. See c-ares/c-ares#794 Signed-off-by: Clif Houck <me@clifhouck.com>
ClifHouck
added a commit
to ClifHouck/envoy
that referenced
this pull request
Mar 10, 2025
In version 1.31.0 c-ares enabled its query cache feature by default. See c-ares/c-ares#786 . This subverted test expectations that each query would be run in the same way. This commit turns it off again in the c-ares dns impl by default. Adds a test to check that query cache is indeed off. Adds a bit of addtional safety around handling TTLs in c-ares dns impl and test code. In PendingTimerEnable test a resolver address is now passed, otherwise c-ares returns an error immediately. The number of expected timeouts is also different because starting in version 1.32.0 c-ares now manages it's own timeout expectations past the first timeout. See c-ares/c-ares#794 Signed-off-by: Clif Houck <me@clifhouck.com>
ClifHouck
added a commit
to ClifHouck/envoy
that referenced
this pull request
Mar 14, 2025
In version 1.31.0 c-ares enabled its query cache feature by default. See c-ares/c-ares#786 . This subverted test expectations that each query would be run in the same way. This commit turns it off again in the c-ares dns impl by default. Adds a test to check that query cache is indeed off. Adds a bit of addtional safety around handling TTLs in c-ares dns impl and test code. In PendingTimerEnable test a resolver address is now passed, otherwise c-ares returns an error immediately. The number of expected timeouts is also different because starting in version 1.32.0 c-ares now manages it's own timeout expectations past the first timeout. See c-ares/c-ares#794 Signed-off-by: Clif Houck <me@clifhouck.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query cache should be enabled by default. This will help with determining proper timeouts for #736. It can still be disabled by setting the ttl to 0. There should be no negative consequences of this in real-world scenarios since DNS is based on the TTL concept and upstream servers will cache results and not recurse based on this information anyhow. DNS queries and responses are very small, this should have negligible impact on memory consumption.
Fix By: Brad House (@bradh352)