Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This library should not fail when new fields are added to the API #117

Closed
Bluexin opened this issue Oct 18, 2021 · 2 comments · Fixed by #119 or Bluexin/themoviedbapi#1
Closed

This library should not fail when new fields are added to the API #117

Bluexin opened this issue Oct 18, 2021 · 2 comments · Fixed by #119 or Bluexin/themoviedbapi#1

Comments

@Bluexin
Copy link
Contributor

Bluexin commented Oct 18, 2021

This can be done by configuring the ObjectMapper in use.
I will create a PR for this.
@Bluexin Bluexin mentioned this issue Oct 18, 2021
Closed
@Bluexin
Copy link
Contributor Author

Bluexin commented Oct 18, 2021

Arguably we could offer full ObjectMapper customization -- if this is wanted another issue should probably be created to discuss how to do it (and if anyone really needs it)

@Bluexin
Copy link
Contributor Author

Bluexin commented Oct 18, 2021 •
edited
Loading

@holgerbrandl after looking into this more I noticed you're using
https://github.com/holgerbrandl/themoviedbapi/blob/dfcbe15ce2d70a65440753230bd66dba85b7844d/src/main/java/info/movito/themoviedbapi/model/core/AbstractJsonMapping.java#L23-L30
I guess this would work but then you need to make every data class extend this AbstractJsonMapping.
Which resolution would you prefer for this ? I can work on a PR.

Bluexin added a commit to Bluexin/themoviedbapi that referenced this issue Oct 18, 2021
@Bluexin
Make the ObjectMapper not fail on unknown properties
90800c1 
Fixes c-eg#117
This was referenced Oct 18, 2021
Merged
Merged
holgerbrandl pushed a commit that referenced this issue Oct 23, 2021
@Bluexin
Make the ObjectMapper not fail on unknown properties (#119)
33612d2 
Fixes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Bluexin