Feat: Badge 컴포넌트 구현 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
se030
approved these changes
Feb 15, 2023
| @@ -30,6 +30,7 @@ function Typography({ variant, children }: TypographyProps) { | |||
| typography, | |||
| { | |||
| css: css` | |||
| margin: 0; | |||
|
|
||
| const BadgeContainer = styled.div<Omit<BadgeProps, 'children' | 'size'>>( | ||
| ({ outline, color, fill }) => ({ | ||
| width: 'fit-content', |
There was a problem hiding this comment.
좋아요~ 최대 길이에 제한은 안둬도 괜찮을까요? (사용자가 착한걸로 ..?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤠 개요
feat/center브랜치에서 새 브랜치 파서 지금은feat/center로 PR 보내요💫 설명
Badge 컴포넌트에서
Typo랑Center를 쓰게 돼서 Badge를 감싸는 컨테이너도 추상화 레벨을 맞춰주려고styled로 했어요.@emotion/styled설치했슴다Typography에 margin이 있어서 Badge가 뚱뚱해졌어요.
Global style따로 빼서 storybook에 설정해주고 패키지에도 같이 넣어서 배포하면 될것같아요.color 상수를 따로 빼야하는데 이건 다른 이슈 파서 할게요.
📷 스크린샷 (Optional)