-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Badge 컴포넌트 구현 #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아쥬 야무집니다
@@ -30,6 +30,7 @@ function Typography({ variant, children }: TypographyProps) { | |||
typography, | |||
{ | |||
css: css` | |||
margin: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
||
const BadgeContainer = styled.div<Omit<BadgeProps, 'children' | 'size'>>( | ||
({ outline, color, fill }) => ({ | ||
width: 'fit-content', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋아요~ 최대 길이에 제한은 안둬도 괜찮을까요? (사용자가 착한걸로 ..?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
글로벌 스타일 정의가 급하겠네요 🤔
🤠 개요
feat/center
브랜치에서 새 브랜치 파서 지금은feat/center
로 PR 보내요💫 설명
Badge 컴포넌트에서
Typo
랑Center
를 쓰게 돼서 Badge를 감싸는 컨테이너도 추상화 레벨을 맞춰주려고styled
로 했어요.@emotion/styled
설치했슴다Typography에 margin이 있어서 Badge가 뚱뚱해졌어요.
Global style
따로 빼서 storybook에 설정해주고 패키지에도 같이 넣어서 배포하면 될것같아요.color 상수를 따로 빼야하는데 이건 다른 이슈 파서 할게요.
📷 스크린샷 (Optional)