Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_value_str change breaking #21

Closed
senorsmile opened this issue May 9, 2016 · 2 comments
Closed

check_value_str change breaking #21

senorsmile opened this issue May 9, 2016 · 2 comments

Comments

@senorsmile
Copy link

this commit seems to have broken my setup:

f3233fb

I'm not quite seeing what the intention is here. Should the warning and critical be specific differently now?

E.g.
./check_json.pl -u 'https://myurl/status/healthcheck/version.json' -a '{version}->{message}' -w 292 -c 290 -v

yields:
$VAR1 = '$check_value = $json_response->{'{version}->{message}'}';
Check JSON status API UNKNOWN - No value received

That output of Dumper: '$check_value = $json_response->{'{version}->{message}'}'
certainly doesn't make any sense to me either.

@k-wall
Copy link

k-wall commented Aug 8, 2016

I agree with sensorsmile's observation. f3233fb has changed the meaning of --attribute. It means you can no longer traverse a structured object. The README.md and the program's usage information is now inconsistent with the implementation.

What was the reason behind the change? It seems to me a useful feature has been lost.

@c-kr
Copy link
Owner

c-kr commented Aug 15, 2016

Thanks for clarification, commit f3233fb was reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants