Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting contract should allow hash execution based on vote resolution. #21

Closed
sirhill opened this issue Aug 16, 2020 · 1 comment
Closed

Voting contract should allow hash execution based on vote resolution. #21

sirhill opened this issue Aug 16, 2020 · 1 comment
Labels
Sponsored
Projects
Roadmap v1.2

Comments

@sirhill
Copy link
Member

sirhill commented Aug 16, 2020

A new function execute(uint256 _proposalId) public returns (bool) should be added to the voting contract.

This function should execute the resolution hash when the vote is successful on a target contract.

In VotingCore, the storage should add an address targetContract field in the Proposal structure.

'hash' should be renamed for clarity into resolutionHash
@sirhill sirhill created this issue from a note in Roadmap v1.2 (To do) Aug 16, 2020
@sirhill sirhill mentioned this issue Aug 16, 2020
Closed
@sirhill
Copy link
Member Author

sirhill commented Aug 27, 2020

Implementation is covered with the following commit:
ec35787

@sirhill sirhill closed this as completed Aug 27, 2020
Roadmap v1.2 automation moved this from To do to Done Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sponsored
Projects
No open projects
Roadmap v1.2
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sirhill